Fix custom theme variables used #863
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sBouzols
reviewed
Sep 22, 2025
| setResizedTreePercentage(newPercentage); | ||
| } | ||
| }; | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars |
There was a problem hiding this comment.
MAybe you could remove this line ? because you change to _event ?
sBouzols
reviewed
Sep 22, 2025
| onSortChanged={onSortChanged} | ||
| getRowId={(row) => row.data[FieldConstants.AG_GRID_ROW_UUID]} | ||
| theme="legacy" | ||
| sx={useMemo(() => style(cssProps).grid, [cssProps])} |
There was a problem hiding this comment.
hum Rules of Hooks : Only call Hooks at the top level, I don't like this useMemo called in the JSX...
sBouzols
reviewed
Sep 22, 2025
| fontSize: 'calc(var(--ag-font-size) + 1px)', | ||
| paddingLeft: 'calc(var(--ag-cell-horizontal-padding) - 1px)', | ||
| width: '100%', | ||
| const style = (customProps: CSSObject) => |
There was a problem hiding this comment.
What is this customProps as parameter of the style object ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #855
Content:
CustomAgGridTable, already done byCustomAGGridCancelButtoncustom color